perf: replace multiple if statements with switch

2022-12-21 11:53:28 +08:00
parent fff2488058
commit c67e639f26
2 changed files with 25 additions and 23 deletions
@@ -40,24 +40,31 @@ func UpdateOption(c *gin.Context) {
 		})
 		return
 	}
-	if option.Key == "GitHubOAuthEnabled" && option.Value == "true" && common.GitHubClientId == "" {
-		c.JSON(http.StatusOK, gin.H{
-			"success": false,
-			"message": "无法启用 GitHub OAuth，请先填入 GitHub Client ID 以及 GitHub Client Secret！",
-		})
-		return
-	} else if option.Key == "WeChatAuthEnabled" && option.Value == "true" && common.WeChatServerAddress == "" {
-		c.JSON(http.StatusOK, gin.H{
-			"success": false,
-			"message": "无法启用微信登录，请先填入微信登录相关配置信息！",
-		})
-		return
-	} else if option.Key == "TurnstileCheckEnabled" && option.Value == "true" && common.TurnstileSiteKey == "" {
-		c.JSON(http.StatusOK, gin.H{
-			"success": false,
-			"message": "无法启用 Turnstile 校验，请先填入 Turnstile 校验相关配置信息！",
-		})
-		return
+	switch option.Key {
+	case "GitHubOAuthEnabled":
+		if option.Value == "true" && common.GitHubClientId == "" {
+			c.JSON(http.StatusOK, gin.H{
+				"success": false,
+				"message": "无法启用 GitHub OAuth，请先填入 GitHub Client ID 以及 GitHub Client Secret！",
+			})
+			return
+		}
+	case "WeChatAuthEnabled":
+		if option.Value == "true" && common.WeChatServerAddress == "" {
+			c.JSON(http.StatusOK, gin.H{
+				"success": false,
+				"message": "无法启用微信登录，请先填入微信登录相关配置信息！",
+			})
+			return
+		}
+	case "TurnstileCheckEnabled":
+		if option.Value == "true" && common.TurnstileSiteKey == "" {
+			c.JSON(http.StatusOK, gin.H{
+				"success": false,
+				"message": "无法启用 Turnstile 校验，请先填入 Turnstile 校验相关配置信息！",
+			})
+			return
+		}
 	}
 	err = model.UpdateOption(option.Key, option.Value)
 	if err != nil {